added CRUD for Chorma Vector store by RonitKiranMurmu · Pull Request #7 · pixelThreaderOfficial/Deep-Researcher-V2

RonitKiranMurmu · 2026-03-02T09:29:52Z

No description provided.

pixelThreader

@RonitKiranMurmu Please Update these changes in the file as instructed and use the DBLogger log the data and please ensure you're not repeating yourself!

use from main.src.utils.versionManagement import getAppVersion for getting the version Dynamically. for instance you can read the DRSecrets.py for looking how I used the logger there!!

backend/main/src/store/DBVector.py

pixelThreader · 2026-03-02T09:52:24Z

backend/main/src/store/DBVector.py

+_std_logger = logging.getLogger(__name__)
+
+try:
+    import chromadb


keep all import statements at top

The try-except block around [import chromadb] is a pattern for optional dependencies.
Here is why it is used instead of a standard top-level import:
Prevents App Crashes: [chromadb] is a heavy library. If a user (or a CI/CD server) doesn't have it installed, a standard [import chromadb] would crash the entire application immediately upon startup. The try-except block allows the app to start even if is missing.
Graceful Handling: It sets the flag [_CHROMA_AVAILABLE] which allows the rest of the code to handle the missing library gracefully (e.g., by setting [db_vector_manager = None] or raising a clear error message like ["Run: uv add chromadb"] when someone actually tries to use it).
If you move it to a bare [import chromadb] at the top, the program will crash instantly with ModuleNotFoundError if the package isn't installed.

So do i make it essential and move it to the top anyway or leave it right there

actually remove the try-catch block from the chromadb that's not important because the backend is setup by experienced developers.

backend/main/src/store/DBVector.py

pixelThreader · 2026-03-02T09:58:22Z

backend/main/src/store/DBVector.py

+                origin="system",
+                module="DB",
+                urgency=urgency,  # type: ignore
+                app_version="1.0",


this is wrong!!

NO HARDCODED VERSION ACCEPTED!!

use from main.src.utils.versionManagement import getAppVersion

then the use the getAppVersion like app_version=getAppVersion()

Updated it to remove hardcoding

no, there is still the version hardcoded

backend/main/src/store/DBVector.py

pixelThreader · 2026-03-02T10:40:05Z

backend/main/src/store/DBVector.py

+    try:
+        chroma_store_dir.mkdir(parents=True, exist_ok=True)
+        _std_logger.info(f"ChromaDB storage directory ensured: {chroma_store_dir}")
+        dr_logger.log(


use the _log function and don't hardcode the version

pixelThreader · 2026-03-02T10:41:10Z

backend/main/src/store/DBVector.py

+            dr_logger.log(
+                log_type="error",
+                message=f"Failed to initialize ChromaDB store directory: {e}",
+                origin="system",
+                module="DB",
+                urgency="critical",
+                app_version="1.0",
+            )


use the _log function and don't hardcode the version

backend/main/src/store/DBVector.py

pixelThreader · 2026-03-02T10:50:00Z

backend/tests/test_db_vector.py

Brother use the logging module and you dont have to write the tests in the logs database!

When running automated tests, we should not pollute the real logs database (logs.db.sqlite3) with test data. Tests should be isolated and "silent" regarding side effects like database writes.

How I addressed it:
I ensured this in two ways:

Mocking the Logger in Tests:
In [test_db_vector.py], the [setUp] method now includes:

self.patcher = patch("main.src.store.DBVector.dr_logger")
self.mock_logger = self.patcher.start()

This intercepts all calls to [dr_logger.log] during tests and sends them to a fake (mock) object instead of the real database. This effectively stops tests from writing to the logs DB.

Preventing Import Side-Effects:
In [DBVector.py], I added this check:

if not any("unittest" in arg for arg in sys.argv) and not any("pytest" in arg for arg in sys.argv):
_initialize_chroma_store()

This ensures that simply importing the file during a test run doesn't trigger the initialization log entry.

So, your tests are now clean and they verify the logic without junking up your actual database logs.

Ronit, I think this is complicated for a quick testing. we can use the logger to log directly in terminal to see the usage.. you don't have to mock into the DB, because the tests don't have to do anything with the logger it will not run at the prod....

So from future you can skip this Mock DB Loggers in test, because those are just complications. just use terminal loggers only!!

…agement

pixelThreader

Reviewed and there are some minor needs just make them then, we're good to merge to main branch.

pixelThreader · 2026-03-03T18:41:28Z

backend/main/src/store/DBVector.py

+_std_logger = logging.getLogger(__name__)
+
+try:
+    import chromadb


actually remove the try-catch block from the chromadb that's not important because the backend is setup by experienced developers.

pixelThreader · 2026-03-03T18:47:16Z

backend/tests/test_db_vector.py

Ronit, I think this is complicated for a quick testing. we can use the logger to log directly in terminal to see the usage.. you don't have to mock into the DB, because the tests don't have to do anything with the logger it will not run at the prod....

So from future you can skip this Mock DB Loggers in test, because those are just complications. just use terminal loggers only!!

pixelThreader · 2026-03-03T21:17:50Z

backend/main/src/store/DBVector.py

+                origin="system",
+                module="DB",
+                urgency=urgency,  # type: ignore
+                app_version="1.0",


no, there is still the version hardcoded

added CRUD for Chorma Vector store

6b8392f

pixelThreader requested changes Mar 2, 2026

View reviewed changes

RonitKiranMurmu requested a review from pixelThreader March 2, 2026 11:20

RonitKiranMurmu added 2 commits March 2, 2026 19:36

Addressing PR comments: Logging update, imports clean up, version man…

bbe4cf6

…agement

Refactor: Extract global _log_db_event function

942038e

pixelThreader requested changes Mar 3, 2026

View reviewed changes

RonitKiranMurmu added 2 commits March 4, 2026 20:40

updated CRUD for Chorma Vector store

5ab717f

async in DBVector

162ec7e

RonitKiranMurmu closed this Mar 18, 2026

Conversation

RonitKiranMurmu commented Mar 2, 2026

Uh oh!

pixelThreader left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RonitKiranMurmu Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pixelThreader left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RonitKiranMurmu Mar 2, 2026 •

edited

Loading